The Author Online Book Forums are Moving

The Author Online Book Forums will soon redirect to Manning's liveBook and liveVideo. All book forum content will migrate to liveBook's discussion forum and all video forum content will migrate to liveVideo. Log in to liveBook or liveVideo with your Manning credentials to join the discussion!

Thank you for your engagement in the AoF over the years! We look forward to offering you a more enhanced forum experience.

43299 (1) [Avatar] Offline
#1
i'm on a windows 10 machine, electron version = 1.7.5. MEAP version = 10.

i'm running the 'Fire Sale' app by typing "npm start" at the command prompt

prior to chapter 5, whenever i close the app window, the main process quits a few seconds later.

with the added code for chapter 5, the main process doesn't quit after i've closed the app window.
i have to ctrl-c to terminate the process after a few minutes.

is this the expected behavior ??

thanks for any help!

EDITED TO ADD:
when i comment out the parts relevant only to macOS, the process is quitting after i close all browser / renderer windows ...
Steve Kinney (33) [Avatar] Offline
#2
Oh, interesting! It should quit. Let me take a look at it and get back to you.
Steve Kinney (33) [Avatar] Offline
#3
Okay! Follow up! This will get it working for you. I'll update the chapter accordingly.

app.on('window-all-closed', () => {
  if (process.platform === 'darwin') {
    return false;
  }
  app.quit();
});