Patrick van Dissel (4) [Avatar] Offline
#1
Hey, good to finally see a Spock Framework book smilie

Please, if at all possible, please be the first book (that I know of) with color-highlighted code samples. We have it in our IDE's, text-editors, blogs, etc. for a reason. It makes code sooo much easier to read.

Maybe for printing it is too costly, I don't know. But then atleast put the code highlighting in the ebook/digital versions smilie (safaribooks? smilie)

I'm very curious to the finished book.

Regards,
Patrick

ps. besides the features described on http://docs.spockframework.org, please also take https://code.google.com/p/spock/w/list (and any new stuff?) into account. As the new docs are still very incomplete. And this very nice BDD-style test reporting extension for Spock: https://github.com/renatoathaydes/spock-reports
Kostis Kapelonis (53) [Avatar] Offline
#2
Hello Patrick

The request of colours in code listings is a very common one. Unfortunately it is outside of my control. I have notified Manning
and they are aware of the situation. If you are reading the electronic book you can look directly at all listings in Github in another window
which of course has full syntax highlighting
https://github.com/kkapelon/java-testing-with-spock#code-listings

Regarding the content:
I am aware of the old wiki, and I am also gathering features from the mailing lists as well. There are also a lot of third-party extensions
for Spock scattered in Github repositories that I find very useful.

Regarding the reports from Renato they are already mentioned in the book! Chapter 3 even has a screenshot.

Thank you for your interest in the book.

Kostis
322672 (3) [Avatar] Offline
#3
Hello,

I'm not too keen on the use of #A, #B format to describe code blocks.

The reason being is I read the code block once, I then have to go read the description of #A, #B etc and then re-read the code block.

I think moving the #A, #B comments into the code block would make it easier to read.

Ian
Patrick van Dissel (4) [Avatar] Offline
#4
Exactly, like asciidoc supports callouts in code:
- http://asciidoctor.org/docs/asciidoc-syntax-quick-reference/#source-code (scroll a bit down to the "callouts" samples)

Code highlighting and inline reference for the win! smilie
Kostis Kapelonis (53) [Avatar] Offline
#5
Hello Ian

The #lines are Manning markup. They are not part of the final book. They will be rendered as arrows in the final text.
I am attaching an example from the "BDD in action" book.

So these # lines are temporary only during MEAP.

Patrick, I find that the Manning Markup is similar to what you suggest for asciidoc (it might be even better because of the arrows)
Also regarding code highlighing I may have some good news. Stay tuned until I confirm.

Should I take it as a good sign that your comments have to do with the style of the book? smilie
Is the actual content ok?

Kostis

Patrick van Dissel (4) [Avatar] Offline
#6
Thanks for update smilie

Sorry, I'm not a MEAP reader. I've only read the free excerpt, which looks good.
I would like to be a MEAP reader, but I'm not too happy with Manning' delivery system for e-books nor their uber-high shipping costs. On which I emailed them, so I hope they will improve on that. If so, I will be happy to be a MEAP reader and happy buyer of Manning books. But until then, I'm holding off on buying Manning books, and hoping this one soon will be on SafariBooksOnline smilie
Kostis Kapelonis (53) [Avatar] Offline
#7
Ok I have good news!

I got approval from Manning and I will use syntax highlighting in the code examples of chapter 4 which is currently in progress.

If that experiment goes well, then code highlighting will be available to all chapters.
Patrick van Dissel (4) [Avatar] Offline
#8
Wow, that's perfect news Kostis. Thanks for pulling strings at Manning and Manning for going with the experiment smilie
Kostis Kapelonis (53) [Avatar] Offline
#9
I am happy to report that all existing chapters in the MEAP have been converted to use syntax highlighting.
And of course the remaining chapters will have colours as well.

I also informed all other Manning authors, so hopefully more Manning books will have coloured code listings from now on.

Kostis